Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some RAKwireless WisBlock based devices #2

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

beegee-tokyo
Copy link
Contributor

@brocaar

I added some basic RAKwireless devices. Please check if we are doing it right.
About the "profiles", these devices are using LoRaMAC stack V1.0.2. I chose a naming that allows to define more profiles for LoRaMAC stack V1.0.3 and V1.0.4 that we will add later.

Copy link
Contributor

@brocaar brocaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 I have added a few comments.

vendors/rakwireless/codecs/test_decode_example.json Outdated Show resolved Hide resolved
vendors/rakwireless/codecs/test_encode_example.json Outdated Show resolved Hide resolved
vendors/rakwireless/devices/wisblock-api-v2.toml Outdated Show resolved Hide resolved
@beegee-tokyo
Copy link
Contributor Author

@brocaar
Changed the file names and removed the ^

@brocaar
Copy link
Contributor

brocaar commented Sep 9, 2024

@beegee-tokyo the test is failing:

Sensor type error!: 66

Could you please check (make sure that the input bytes are integers, not hex).

@beegee-tokyo
Copy link
Contributor Author

@brocaar
Can you try again

@brocaar
Copy link
Contributor

brocaar commented Sep 9, 2024

(I deleted my prev. comment).

Could you update the common-names to match the Regional Parameters values? Sorry I have missed this in my review:

image

(AS923_1 -> AS923, AS923_2 -> AS923-2, ...)

@beegee-tokyo
Copy link
Contributor Author

@brocaar
Done.

@brocaar brocaar merged commit 1e6286d into chirpstack:master Sep 9, 2024
1 check passed
@brocaar
Copy link
Contributor

brocaar commented Sep 9, 2024

Thanks @beegee-tokyo for adding the first real device :-) All tests are passing and I have merged your PR.

@beegee-tokyo
Copy link
Contributor Author

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants