Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix install support for vhs >= v0.7.2 #11

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

polds
Copy link
Contributor

@polds polds commented Jun 14, 2024

Charm changed how they build their artifacts to include a directory when extracted. This adds support to detect the directory and use the binary there.

Fixes #10

Manual verification:

$ asdf plugin test vhs https://github.com/polds/asdf-vhs.git "vhs --version"
Location of vhs plugin: /var/folders/l1/61srltb90tv8bsddv63lnjp40000gp/T/asdf.XXXX.hhbcB3Xfu4/plugins/vhs
Updating vhs to main
Already on 'main'
Your branch is up to date with 'origin/main'.
* Downloading vhs release 0.7.2...
vhs 0.7.2 installation was successful!
vhs version v0.7.2 (484e440)

Charm changed how they build their artifacts to include a directory when extracted. This adds support to detect the directory and use the binary there.
This is because the platform is `linux` vs the published artifact `Linux`. There’s a case for Darwin, but this seems like a more forward ready option.
@chessmango
Copy link
Owner

Thanks very much for the contribution! I'd been meaning to get round to this for a while <3

@chessmango chessmango merged commit 2403f6d into chessmango:main Jun 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packaging changes between 0.7.1 and 0.7.2
2 participants