Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added MsgBurn per signer #783

Open
wants to merge 50 commits into
base: develop
Choose a base branch
from
Open

feat: Added MsgBurn per signer #783

wants to merge 50 commits into from

Conversation

vishal-kanna
Copy link
Collaborator

No description provided.

@vishal-kanna
feat: integrated feemarket
89c3505
@vishal-kanna
chore: updated anteHandler and postHandler
defe327
@vishal-kanna
chore: use replace for feemarket in go.mod
5e33e65
@vishal-kanna
chore: changed go version in docker file
d5667f0
@vishal-kanna
fix : fix testing in antehandler
8684ce9
@vishal-kanna
fix: fix lint issues
ea06beb
@vishal-kanna
chore: updated antehandler
d09e816
@vishal-kanna
fix: fix lint issues
adcd9f3
@vishal-kanna
fix: fix lint issues
e2f6a74
@vishal-kanna
fix: lint issus
f016460
@vishal-kanna
chore: updated ante and fix test cases
36202e4
@vishal-kanna
fix: gofumt errors
945b3cc
@vishal-kanna
fix: golint issues
74089c2
@vishal-kanna
chore: updated postHandler
4256d7f
@vishal-kanna
testing
acd8d74
@vishal-kanna
chore: added test cases
4779b6a
@vishal-kanna
fix
9557978
@vishal-kanna
fix
044bc3d
@vishal-kanna
fix: golint issues
b2b8502
@vishal-kanna
fix : fix testcase
e2866fb
@vishal-kanna
fix: fix lint issues
9bcd0cb
@vishal-kanna
disable update tests
64c505d
@vishal-kanna
disable report test
b05f6ee
@vishal-kanna
fix: added response check in tests
9af6f82
@vishal-kanna
fix
6181458
@vishal-kanna
chore: added param subsace for feemarket
33403e1
@vishal-kanna
feat: added burn mechanism
6e447db
@vishal-kanna
chore: added burn msg proto
f73e0ba
@vishal-kanna
addressed review comments
05fa0ec
@vishal-kanna
chore: merged feemarket integration PR
281af5e
@vishal-kanna vishal-kanna changed the title Vishal/burn msg feat:added MsgBurn Sep 10, 2024
@vishal-kanna vishal-kanna marked this pull request as ready for review September 13, 2024 05:59
Eengineer1
Eengineer1 requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@Eengineer1 Eengineer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core work looks good.

Please, address + resolve the relevant validation logic remarks, before that's ready to merge.

x/did/client/cli/burn_cli.go Outdated Show resolved Hide resolved
x/did/keeper/msg_server.go Outdated Show resolved Hide resolved
x/did/types/tx_msg_burn.go Outdated Show resolved Hide resolved
@Eengineer1 Eengineer1 changed the title feat:added MsgBurn feat: Added MsgBurn per signer Sep 19, 2024
Base automatically changed from vishal/integrate-antehandler to develop September 20, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eengineer1 Eengineer1 Awaiting requested review from Eengineer1

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishal-kanna @Eengineer1