feat: improve filters panel #3248
Merged
+2,874
−1,167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Deploying nmrium with
|
| Latest commit: |
e1a15e5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27e22af5.nmrium.pages.dev |
| Branch Preview URL: | https://improve-filters-panel.nmrium.pages.dev |
hamed-musallam
force-pushed
the
improve-filters-panel
branch
3 times, most recently
from
1d487d6
to
631c924
Compare
|
The functionnality looks very good ! Thanks @hamed-musallam ! |
hamed-musallam
force-pushed
the
improve-filters-panel
branch
from
e5e77e9
to
7b7949f
Compare
hamed-musallam
force-pushed
the
improve-filters-panel
branch
7 times, most recently
from
b02b413
to
d09eaa4
Compare
refactor: improve section inner header and body refactor: improve Section component to render active section content only refactor: improve section header to be sticky refactor: rename 'SectionsItem' to 'SectionItem'
hamed-musallam
force-pushed
the
improve-filters-panel
branch
8 times, most recently
from
dc3bce8
to
b616c3a
Compare
refactor: disable the delete filter option when deletion is not permitted refactor: remove FiltersTable component
create two synchronized options panels: a simplified one in the header and an advanced one in the processing section.
create two synchronized options panels: a simplified one in the header and an advanced one in the processing panel. test: fix phase correction combobox selector refactor: enable actions buttons when apodization options are changed
refactor: enable actions buttons when zero filling options are changed
create two synchronized options panels: a simplified one in the header and an advanced one in the processing panel.
create two synchronized options panels: a simplified one in the header and an advanced one in the processing panel. refactor: enable actions buttons when baseline correction options are changed refactor: enable action buttons when baseline correction options are changed
refactor: enable action buttons when shift options are changed
test: do not toggle open the processings panel
hamed-musallam
force-pushed
the
improve-filters-panel
branch
from
a272ce6
to
e1a15e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.