Add transaction.update route
#8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Converts Models to use pydantic for type validation & some object serialization. - Also uses pydantic's type validation of incoming data on Requests. - Uses improved API for customizing json serialization of Route Responses.
Solves bugs with 1.4.x in migra.
Latest version introduced some package not found bugs in my system & this dependency isn't critical for production performance or safety. Instead of debugging, pinning is the simplest solution for now.
|
@CrackerJack625 Route is completed & all integration tests pass. Ready for review. This route uses the Model features from my db_wrapper library. This feature introduces pydantic as a dependency as of db_wrapper version 2.0, which gives the routes runtime type validation on inputs & outputs. If you want me to review any of this with you live I'd be happy to go over it with you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2