Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(viewport): preempt potential panics when calculating visible lines #608

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(viewport): preempt potential panics when calculating visible lines #608

wants to merge 1 commit into from
+15 −5

Conversation

meowgorithm
Copy link
Member

This adds some checks to prevent slice out-of-bounds errors when calculating visible lines in the viewport.

This will fix the panic we're seeing in charmbracelet/gum#660 (comment) (though we still need to address the zero-height-by-default thing).

@meowgorithm meowgorithm mentioned this pull request Sep 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 Awaiting requested review from caarlos0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@meowgorithm