fix(textinput): wrong placeholder/completion rendering #560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
TODO/discuss:
Some examples, using contrasting colors for easier identification. Showing a half box below just to see the width, and appended a "Ñ" to see the end of the input view.
Before fix:
Width set to 10, showing the placeholder color:
Extra padding after completion (what should be appended without completion), and the color under the cursor is what should be displayed for the whole completion:
Wrong completion character showing under cursor when overflowing (should show a 'k'):
After fix:
Correct completion style applied:
Correct completion char used under cursor when overflowing: