-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix for (#329) support for regional language codes #339
Conversation
little refactor of locale code, CustomActivity.setLocale now parses language for itself, even for system provided language code
Can one of the core team members give me the the permission to test this? |
ok to test |
@bekuno Can you review the code? |
src/main/java/menion/android/whereyougo/gui/extension/activity/CustomActivity.java
Show resolved
Hide resolved
src/main/java/menion/android/whereyougo/gui/extension/activity/CustomActivity.java
Show resolved
Hide resolved
The PR looks codewise fine. |
@sk-juroot |
Guess there will be no harm in postponing this fix (along with required restart) into another release, there will be some time to reconsider settings in Crowdin and fine-tune expected results. |
As |
Fixes #329
Description
Reworked
CustomActivity.setLocale()
to internally handle regional and non-regional language codes on various system versions.Related issues
Additional context
This code contains hardcoded check for Portuguese language (as the only regional-coded language in this project right now), since various Android devices may report this language as non-regional, causing falling back to English even when proper language asset is present.