Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix for (#329) support for regional language codes #339

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

sk-juroot
Copy link
Contributor

@sk-juroot sk-juroot commented Jan 3, 2022

Fixes #329

Description

Reworked CustomActivity.setLocale() to internally handle regional and non-regional language codes on various system versions.

Related issues

Additional context

This code contains hardcoded check for Portuguese language (as the only regional-coded language in this project right now), since various Android devices may report this language as non-regional, causing falling back to English even when proper language asset is present.

little refactor of locale code, CustomActivity.setLocale now parses language for itself, even for system provided language code
@cgeo-ci-bot
Copy link
Collaborator

Can one of the core team members give me the the permission to test this?

@Lineflyer
Copy link
Member

ok to test

@Lineflyer
Copy link
Member

@bekuno Can you review the code?

@bekuno
Copy link
Member

bekuno commented Jan 3, 2022

@bekuno Can you review the code?

The PR looks codewise fine.
But I did not tested it on a real device.

@Lineflyer
Copy link
Member

@sk-juroot
What do you think?
Shall we include this into the upcoming release or better merge after release to have more time for testing in emulator and in our nightlies?

@sk-juroot
Copy link
Contributor Author

@Lineflyer
Shall we include this into the upcoming release or better merge after release to have more time for testing in emulator and in our nightlies?

Guess there will be no harm in postponing this fix (along with required restart) into another release, there will be some time to reconsider settings in Crowdin and fine-tune expected results.

@Lineflyer
Copy link
Member

As master is separated from release now (see branch handling in readme) its fine to merge and test this on master= in nightlies

@Lineflyer Lineflyer merged commit c4e40f5 into cgeo:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WhereYouGo not using correct default language
4 participants