Regional languages support #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setting locale before loading main settings view resources
explicitly defined system language selection on default language choice, added code for better compatibility with APIs < 24
little refactor of locale code, CustomActivity.setLocale now parses language for itself, even for system provided language code
|
Can one of the core team members give me the the permission to test this? |
|
Ok to test |
|
@sk-juroot Your local branch also contains the commits already merged as part of #332. Can you rebase / recreate this PR as on top fixes based on current |
|
Sure, will open another PR from different branch to merge this change |
bekuno
reviewed
Jan 3, 2022
Comment on lines
+271
to
+273
| if (loc[0].equals("pt")) { | ||
| // nasty hotfix for Portuguese language selected without regional code | ||
| locale = new Locale(loc[0], loc[0]); |
There was a problem hiding this comment.
Let's do it the way around - rename the language pt_PT to pt.
I created Issue #342 for it.
After that these lines are not more necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworked
CustomActivity.setLocale()to internally handle regional and non-regional language codes on various system versions.Related issues
Additional context
This code contains hardcoded check for Portuguese language (as the only regional-coded language in this project right now), since various Android devices may report this language as non-regional, causing falling back to English even when proper language asset is present.