Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use uvchr_to_utf8_flags instead of uvuni_to_utf8_flags (which is remo… #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ernix
Copy link
Contributor

@ernix ernix commented Jul 24, 2023

@ernix
Copy link
Contributor Author

ernix commented Jul 24, 2023

@pgnd
Copy link

pgnd commented Jan 12, 2024

@cfaerber

could you merge this and push update to CPAN ?

cpan build/install of Net::IDN::Encode on

fedora 39

logs a warning,

	lib/Net/IDN/Punycode.xs:256:19: warning: implicit declaration of function ‘uvuni_to_utf8_flags’; did you mean ‘uvchr_to_utf8_flags’? [-Wimplicit-function-declaration]
	  256 |                   uvuni_to_utf8_flags((U8*)skip_p, n, UNICODE_ALLOW_ANY);
	      |                   ^~~~~~~~~~~~~~~~~~~
	      |                   uvchr_to_utf8_flags

but on
fedora rawhide

fails at an error

	lib/Net/IDN/Punycode.xs:256:19: error: implicit declaration of function ‘uvuni_to_utf8_flags’; did you mean ‘uvchr_to_utf8_flags’? [-Werror=implicit-function-declaration]
	  256 |                   uvuni_to_utf8_flags((U8*)skip_p, n, UNICODE_ALLOW_ANY);
	      |                   ^~~~~~~~~~~~~~~~~~~
	      |                   uvchr_to_utf8_flags

this patch is currenty applied to the distro release,

https://src.fedoraproject.org/rpms/perl-Net-IDN-Encode/blob/rawhide/f/Net-IDN-Encode-2.500-use_uvchr_to_utf8_flags_instead_of_uvuni_to_utf8_flags.patch

karenetheridge added a commit to karenetheridge/Net-IDN-Encode that referenced this pull request Jan 12, 2024
@karenetheridge
Copy link

karenetheridge commented Jan 12, 2024

I've uploaded the fix in Net-IDN-Encode-2.501-TRIAL.tar.gz (https://github.com/karenetheridge/Net-IDN-Encode).

@pgnd
Copy link

pgnd commented Jan 31, 2024

fyi, unresponsive maintainer request @

https://www.nntp.perl.org/group/perl.module-authors/2024/01/msg11267.html

@karenetheridge
Copy link

@cfaerber Are you still interested in maintaining this module? There have been some inquiries about making this fix (which I uploaded as a TRIAL release in January 2024) into a stable release so it can be more easily used.

I see you haven't been seen on github since January 2022, so I hope you are well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants