Update controller to issue certs asynchronously #338
+244
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bmsiegel
reviewed
Sep 20, 2024
| CertificateArn: aws.String(*issueOutput.CertificateArn), | ||
| CertificateAuthorityArn: aws.String(p.arn), | ||
| } | ||
| metav1.SetMetaDataAnnotation(&cr.ObjectMeta, "aws-privateca-issuer/certificate-arn", *issueOutput.CertificateArn) |
|
https://github.com/cert-manager/aws-privateca-issuer/actions/runs/10948823902/job/30402060073 Testing failed on the e2e_test |
anbaig
reviewed
Sep 20, 2024
Signed-off-by: Alex Richman <[email protected]>
ARichman555
force-pushed
the
async-certs
branch
from
335911c
to
d03dde8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help resolve #334
This changes our Reconcile loop to not wait until the certificate is issued, effectively making the certificate issuance asynchronous.