Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of ATLAS Open Data for Research scripts #230

Conversation

zlmarshall
Copy link

Hi @tiborsimko , all,

This is a very early attempt at adding the scripts in that are necessary for generating the Open Data Portal records for the ATLAS Open Data for Research. I'm hoping to get a little feedback on the json while we're finishing getting all the necessary files to the rucio endpoint. Most are already there, and file locations on eos can be provided if that's what we need.

This is my first pull request here, so apologies if I'm doing something wrong (I didn't identify a contrib file for this repo).

The python is very much in a thrown-together state. If I need to tidy it to comply with some coding guidelines, let me know (but I think this is a function-over-form setup here; correct me if I'm wrong!).

Thanks,
Zach

atlas-2024-odfr/mkjson.py Outdated Show resolved Hide resolved
atlas-2024-odfr/mkjson.py Outdated Show resolved Hide resolved
atlas-2024-odfr/mkjson.py Outdated Show resolved Hide resolved
atlas-2024-odfr/mkjson.py Show resolved Hide resolved
atlas-2024-odfr/mkjson.py Show resolved Hide resolved
atlas-2024-odfr/mkjson.py Outdated Show resolved Hide resolved
atlas-2024-odfr/mkjson.py Outdated Show resolved Hide resolved
atlas-2024-odfr/mkjson.py Outdated Show resolved Hide resolved
atlas-2024-odfr/mkjson.py Show resolved Hide resolved
atlas-2024-odfr/mkjson.py Outdated Show resolved Hide resolved
@tiborsimko tiborsimko force-pushed the ATLAS_2024_OpenDataForResearch_FirstRelease branch from c139279 to dc5c3a0 Compare September 9, 2024 15:57
Copy link
Member

@tiborsimko tiborsimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, add the index file creation script on top, added links to the global README, added you as a co-author to the list of authors (together with a few past missed ones), and rebase the commits to squash a few together.

@tiborsimko tiborsimko merged commit dc5c3a0 into cernopendata:master Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants