-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First draft of ATLAS Open Data for Research scripts #230
Merged
tiborsimko
merged 12 commits into
cernopendata:master
from
zlmarshall:ATLAS_2024_OpenDataForResearch_FirstRelease
Sep 9, 2024
Merged
First draft of ATLAS Open Data for Research scripts #230
tiborsimko
merged 12 commits into
cernopendata:master
from
zlmarshall:ATLAS_2024_OpenDataForResearch_FirstRelease
Sep 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiborsimko
reviewed
Apr 26, 2024
tiborsimko
reviewed
May 15, 2024
First draf of ATLAS Open Data for Research scripts.
Significant updates in preparation for first open data release. Data now at CERN.
Updating with third batch of MC simulations. More than 99% done.
Final set of MC transferred to CERN. All ready for release. Little updates to record generation scripts now that drafts are visible on the QA instance.
tiborsimko
force-pushed
the
ATLAS_2024_OpenDataForResearch_FirstRelease
branch
from
September 9, 2024 15:57
c139279
to
dc5c3a0
Compare
tiborsimko
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, add the index file creation script on top, added links to the global README, added you as a co-author to the list of authors (together with a few past missed ones), and rebase the commits to squash a few together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tiborsimko , all,
This is a very early attempt at adding the scripts in that are necessary for generating the Open Data Portal records for the ATLAS Open Data for Research. I'm hoping to get a little feedback on the json while we're finishing getting all the necessary files to the rucio endpoint. Most are already there, and file locations on eos can be provided if that's what we need.
This is my first pull request here, so apologies if I'm doing something wrong (I didn't identify a contrib file for this repo).
The python is very much in a thrown-together state. If I need to tidy it to comply with some coding guidelines, let me know (but I think this is a function-over-form setup here; correct me if I'm wrong!).
Thanks,
Zach