This repository has been archived by the owner on May 24, 2024. It is now read-only.
Updating ApplicationBase for v2 architecture #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unsaved changes handling from ApplicationBase.
tbiethman
requested review from
dkasper-was-taken,
emilyrohrbough,
mjhenkes,
ryanthemanuel and
StephenEsser
as code owners
tbiethman
commented
Apr 14, 2021
| i18nLoader(finalLocale).then(translationsModule => { | ||
| setMessages(translationsModule.default); | ||
| }).catch((error) => { | ||
| logger.error(error); |
There was a problem hiding this comment.
I removed the thrown error here. If locales cannot be loaded, we will log and continue rendering null. Throwing an error seemed like overkill (and it was hard to test).
tbiethman
changed the title
yuderekyu
approved these changes
Apr 19, 2021
mjhenkes
approved these changes
Apr 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating ApplicationBase to align better with ApplicationContainer development. Introducing changes made in the v1 pipeline since branch creation.
Closes #184
Deployment Link
https://terra-applic-.herokuapp.com/
Testing
New unit tests have been written. Existing wdio tests using ApplicationBase continue to pass.
Additional Details
Thank you for contributing to Terra.
@cerner/terra