This repository has been archived by the owner on May 7, 2024. It is now read-only.
Review and Corrections for Device #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoCrespo-ora
requested review from
ashu-bdvt,
gmodrogan,
amcginn,
krycunn and
kckeim
kckeim
suggested changes
Sep 20, 2023
There was a problem hiding this comment.
The _id/patient section should actually be broken apart on line 65
It's two separate inputs, so, it could be "provided with the _id or patient parameters" instead of as-written.
I like these other changes, especially since we're removing a lot of duplicated / unnecessary content. I'm not sure if we want to keep the different "kinds" of authorizations' requests in there, since the request is functionally the same, and retrieves the same information either way, unless Aaron or someone else sees it as necessary to keep in there.
kckeim
approved these changes
Sep 21, 2023
|
Thanks for the correction under the _revinclude parameter, @RicardoCrespo-ora |
|
the duplicate content has bugged me for so long, thank you 🥲 |
amcginn
approved these changes
Sep 21, 2023
RicardoCrespo-ora
force-pushed
the
device-docs-migrate
branch
from
8e7f3ef
to
ae6c44e
Compare
kckeim
approved these changes
Sep 25, 2023
balanionut-cerner
approved these changes
Sep 27, 2023
Surya-Rnsit
pushed a commit
that referenced
this pull request
Sep 28, 2023
* Review and corrections for ChargeItem (#976) * typo fix for CapabilityStatement (#977) * fixing URLs for scope and purpose in consent (#979) * Updated DSTU2 care-plan (#980) * Updated R4 CarePlan Resource (#981) * Updated R4 CareTeam Resource (#982) * Updated R4 CareTeam Resource (#983) * Updated DSTU2 Binary Resource (#984) * Review and Corrections for Device (#985) * Consent updated examples (#986) * Updated AllergyIntolerance R4 resource (#987) * Custom encounter search (#989) * Updated AllergyIntolerance DSTU2 resource (#990)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In preparation for migrating to Oracle docs, we are reviewing and correcting any inconsistencies, typos, broken links, etc. This PR aims to correct any of the above that needs to be addressed within Consent/Contract and any other information directly referenced by it.
Modified implementation notes to match styling of other pages
Before
After
Search request and response was being showcased twice, removed the duplicate
Before
After
Duplicated Response/Request for /Device/:id
Before
After
Minor formatting to error example title for readability
Before
After
PR Checklist