Skip to content
This repository has been archived by the owner on May 7, 2024. It is now read-only.

Person updates for DSTU2 and R4 #1009

Merged
merged 7 commits into from
Dec 16, 2023
Merged

Person updates for DSTU2 and R4 #1009

merged 7 commits into from
Dec 16, 2023

Conversation

amcginn
Copy link
Member

@amcginn amcginn commented Oct 26, 2023

Description

DSTU2

  • Updated field list URLs to 'https'
  • "id" -> "ID" throughout
  • Field descriptions
    • Updated info links to 'https'
  • Moved disclaimer and errors to top
    • image
    • image
  • Updated Search params table format/descriptions
    • image
    • image
  • person-combine description
    • Removed quotes
    • Removed unsupported workflow statement
    • image
    • image

R4

  • "id" -> "ID" throughout
  • Removed "(Cerner alias Federated Person Principal)" from field list description
  • Examples
    • Removed all but one identifier
    • Removed all but one name
    • Updated email and address text
  • Moved disclaimer and errors to top
    • image
    • image
  • Updated Search params table format/descriptions
    • image
    • image
  • Updated Search example to use identifier
    • image
    • image
  • person-combine description
    • Removed quotes
    • Removed unsupported workflow statement
    • image
    • image
  • Field descriptions
    • Corrected system URL
    • image
    • image

PR Checklist

  • Screenshot(s) of changes attached before changes merged.
  • Screenshot(s) of changes attached after changes merged and published.

@kckeim kckeim added R4 Applies to R4 FHIR resources DSTU2 Applies to DSTU2 FHIR resources labels Oct 27, 2023
Copy link
Contributor

@kckeim kckeim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unchanged, so I couldn't flag it in-context: please HTTPS-ify the field_name_base_url in dstu2's person.yaml.
Current:
field_name_base_url: http://hl7.org/fhir/DSTU2/person-definitions.html#Person

Beyond that, a couple comments is all. Thanks for being patient while I took forever to get here. Nothing from my side that would stop this from merging.

content/millennium/dstu2/entities/person.md Outdated Show resolved Hide resolved
content/millennium/r4/base/individuals/person.md Outdated Show resolved Hide resolved
Copy link
Contributor

@cldeitrich cldeitrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OHAIUAD-204315: Approved for style.

@amcginn amcginn merged commit 0ac5dd7 into main Dec 16, 2023
1 check passed
@amcginn amcginn deleted the person-updates branch December 16, 2023 17:04
SukeshKonjeti added a commit that referenced this pull request Feb 2, 2024
* Updated MedicationAdminstration R4 Resource (#1010)
* Updated MedicationAdministration DSTU2 Resource (#1011)
* Review and Updates to Goal (#1027)
* Review and Updates to Communication (#1022)
* dstu2 Practitioner updates (#1014)
* R4 Practitioner updates (#1015)
* Person updates for DSTU2 and R4 (#1009)
* StructureDefinition updates (#1012)
* Updated Medication Order DSTU2 Resource (#1020)
* Updated MedicationStatement DSTU2 Resource (#1021)
* Updated MedicationRequest R4 Resource (#1019)
* Updated Provenance R4 Resource (#1018)
* DSTU 2 Patient updates (#1023)
* R4 Patient formatting and standard updates (#1028)
* R4 Observation,DocumentReference Documentation Updates (#1031)
* R4 Encounter Period StartDateTime Sort Update (#1033)
* updated Location type search parameter and examples for physicalType (#1034)
* [R4][DiagnosticReport][DocumentReference] support search by _lastUpdated (#1032)
* [R4][Immunization] Support search by _lastUpdated (#1029)
* R4 Binary Autogen CCD add encounter parameter (#1035)
* [R4][Immunization] Documentation Update (#1036)
@Surya-Rnsit
Copy link
Contributor

Validated after the code is published:
Screenshot 2024-02-02 at 3 40 44 PM
Screenshot 2024-02-02 at 3 38 27 PM
Screenshot 2024-02-02 at 3 38 03 PM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DSTU2 Applies to DSTU2 FHIR resources R4 Applies to R4 FHIR resources
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants