Redesign reports #2461
Redesign reports #2461
Conversation
|
PR deployed in Google Cloud |
|
PR deployed in Google Cloud |
kattylucy
force-pushed
the
pool_overview_redesign
branch
from
90bc09f
to
4afb124
Compare
kattylucy
force-pushed
the
redesign_reports
branch
3 times, most recently
from
5f57f06
to
49a8307
Compare
kattylucy
force-pushed
the
redesign_reports
branch
2 times, most recently
from
eff41c1
to
472f289
Compare
There was a problem hiding this comment.
Looking good! Let's clean up the any types though!
Let's update the url path for reports to match the tab label (reporting --> reports)
Somehow the boarder around these inputs has been lost, can we bring it back so it looks the same as all of the other inputs?
| import { formatPoolFeeTransactionType } from './utils' | ||
|
|
||
| type ReportFilterProps = { | ||
| pool: Pool |
There was a problem hiding this comment.
I would recommend passing just the poolId as a prop and fetch the pool based on the id
| @@ -49,6 +49,9 @@ export type ReportContextType = { | |||
|
|
|||
| loan: string | |||
| setLoan: (type: string) => void | |||
|
|
|||
| reportData: any | |||
There was a problem hiding this comment.
can we do better than any?
| const transformDataChart = React.useMemo(() => { | ||
| if (!reportData.length) return | ||
| if (report === 'balance-sheet') { | ||
| return reportData.map((data: any) => ({ |
There was a problem hiding this comment.
more any 😬 if reportData is typed you don't have to cast data
| yAxis: new CurrencyBalance(data.netAssetValue, pool.currency.decimals).toNumber(), | ||
| })) | ||
| } else if (report === 'profit-and-loss') { | ||
| return reportData.map((data: any) => { |
kattylucy
force-pushed
the
redesign_reports
branch
from
472f289
to
3b1e1f7
Compare
- Formatting now accepts and converts negative numbers - Icon changes color accordingly - Graph is rendering bars accordingly
kattylucy
force-pushed
the
redesign_reports
branch
from
3b1e1f7
to
370c4e1
Compare
#2459
Approvals