chore: upgrade to Go 1.23.1

[rootulp]

Description

Upgrade to Go 1.23.1 motivated by #3847. I had to modify GoReleaser config because goreleaser/goreleaser#5127.

Maintainers need to update their local golangic-lint binary to v1.61.0. See golangci-lint install.

[coderabbitai]

Walkthrough

Walkthrough

This pull request includes updates to various configuration files and dependencies in the project. Key changes involve upgrading the versions of tools such as golangci-lint, Go itself, and Docker images, as well as modifications to linting configurations and test files to enhance code clarity and correctness. Additionally, adjustments are made to documentation files to improve formatting and ensure up-to-date information regarding dependencies.

Changes

File	Change Summary
.github/workflows/lint.yml	Updated golangci-lint-action version from v1.59.1 to v1.60.3 and removed skip-pkg-cache.
.golangci.yml	Replaced exportloopref linter with copyloopvar.
.goreleaser.yaml	Renamed name_template to version_template in the snapshot section.
Dockerfile	Updated BUILDER_IMAGE from docker.io/golang:1.22.6-alpine3.19 to docker.io/golang:1.23.1-alpine3.19.
Makefile	Changed GOLANG_CROSS_VERSION from v1.22.6 to v1.23 and added a comment about verifying Docker images.
README.md	Updated Go version from 1.22.6 to 1.23.1 and golangci-lint version from 1.59.1 to 1.60.3.
app/test/priority_test.go	Removed variable shadowing in TestPriorityByGasPrice.
docker/Dockerfile_txsim	Updated base image from 1.22.6-alpine3.19 to 1.23.1-alpine3.19.
docs/maintainers/release-guide.md	Minor formatting adjustment and added emphasis on Upgrade Notice section in release notes.
go.mod	Updated Go version to 1.23.1, updated github.com/klauspost/compress to v1.17.8, and added replace directive for github.com/grafana/pyroscope-go/godeltaprof.
go.work.example	Updated Go version from 1.22.6 to 1.23.1.
pkg/da/data_availability_header_test.go	Removed redundant variable shadowing in test functions.
test/interchain/go.mod	Updated Go version from 1.22.6 to 1.23.1.
tools/blocketa/README.md	Adjusted URL formatting in notes for clarity.

Possibly related PRs

• chore(deps): upgrade to celestia-core v1.37.0-tm-v0.34.29 #3607: The changes in this PR involve updating the Golang version in the Dockerfile and Makefile, which is directly related to the version update of golangci-lint from v1.59.1 to v1.60.3 in the main PR.
• chore(deps): upgrade to cosmos-sdk v1.23.0 #3629: This PR updates the Go module dependencies, including the version of golangci-lint, which aligns with the version update in the main PR.
• chore(go.mod): bump grafana/pyroscope-go deps #3849: This PR also involves a bump in the version of github.com/klauspost/compress, which is relevant as the main PR updates the Go version and may affect compatibility with other dependencies.

Suggested labels

external

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

tools/blocketa/README.md (1)

18-18: Add a newline at the end of the file.

The static analysis tool suggests adding a single newline character at the end of the file. This is a good practice for file formatting.

 > The block time is currently hard-coded. If you're running this for a network with a different block time, you'll need to update the `blockTime` constant in the main.go file. You can use [https://www.mintscan.io/celestia/block](https://www.mintscan.io/celestia/block/) or the blocktime tool.
+

Tools

Markdownlint

18-18: null
Files should end with a single newline character

(MD047, single-trailing-newline)

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3ab7627 and 9b6980b.

Files selected for processing (1)

• tools/blocketa/README.md (1 hunks)

Additional context used

Markdownlint

tools/blocketa/README.md

18-18: null
Files should end with a single newline character

(MD047, single-trailing-newline)

Additional comments not posted (1)

tools/blocketa/README.md (1)

18-18: LGTM!

The change to the URL formatting improves the readability of the documentation.

Tools

Markdownlint

18-18: null
Files should end with a single newline character

(MD047, single-trailing-newline)

[ninabarbakadze]

utAck

[rootulp]

There's a bug in Go 1.23 golang/go#69312 that is impacting celestia-node so let's hold off on merging this until we identify if the same issue may hit us.

[rach-id]

Added some more bumps in case we want to bump everything that is bumpable that's related to go version.

Btw, I already bumped core to 1.23.1. If the bug is infecting that too, we can revert ASAP