Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async benchmark for logback-logstash-encoder #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

brenuart
Copy link

The logback-logstash-encoder (LLE) project comes with an AsyncDisruptorAppender wrapper that can be used to log asynchronously to an otherwise synchronous appender.

This PR adds a benchmark in the AsyncWithFileAppenderBenchmark test suite to evaluate the LLE async solution alongside the other ones.

A few points about the integration:

  • Instead of creating a separate logback configuration file, I reused the existing one and added a new appender named "LLE"
  • The "LLE" logger category logs to this new appender and has additivity turned off to avoid logging into the other appender as well
  • The logbackLleFile benchmark logs directly to the LLE category to target the LLE appender.

Thanks for considering adding this benchmark to your suite.

Add a benchmark based on async support provided by logback-logstash-encoder.
@brenuart brenuart changed the title Add Async benchmark for logback-logstash-encoder Add async benchmark for logback-logstash-encoder Nov 15, 2021
The LLE-FILE appender is not started when declared "inside" the LLE appender.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant