Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: small fix in event bridge and s3 message bus adapter #144

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

ThomasAribart
Copy link
Contributor

Description 🦫

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change 📝

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧑‍🔬

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration: 🔧

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist: ✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasAribart ThomasAribart marked this pull request as ready for review August 29, 2023 12:14
@github-actions github-actions bot added the patch label Aug 29, 2023
@ThomasAribart ThomasAribart force-pushed the small-fix-in-eb-s3-message-bus-adapter branch from e8e2b32 to 1d3e166 Compare August 29, 2023 12:16
@github-actions github-actions bot added patch and removed patch labels Aug 29, 2023
@ThomasAribart ThomasAribart merged commit be8529d into main Aug 29, 2023
4 checks passed
@ThomasAribart ThomasAribart deleted the small-fix-in-eb-s3-message-bus-adapter branch August 29, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant