Add a way to provide a file name for Snapshots #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnusvs
force-pushed
the
feature/snapshot-file-name
branch
from
4ec0ba2
to
3c9f862
Compare
Adds a FileNameProvider that can be implemented in any way to specify file names for a recorded Snapshot. Closes feature request cashapp#549
magnusvs
force-pushed
the
feature/snapshot-file-name
branch
from
3c9f862
to
43229ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a FileNameProvider that can be implemented in any way to specify file names for a recorded Snapshot.
Fixes #549
We wanted this feature because we had a developer on Linux with ecryptfs which only supports file names up to 143 characters, and we we're exceeding this with the current Snapshot file names.