Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ABAC & JSON related test cases #376

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

LMay001
Copy link
Contributor

@LMay001 LMay001 commented Feb 3, 2024

part of #367
1.feat:add JSON process for ABAC model
2.sync test case TestABACMapRequest and TestABACTypes

@casbin-bot
Copy link
Member

@tangyang9464 @imp2002 please review

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (00bc8e8) 69.03% compared to head (86930d7) 69.02%.

Files Patch % Lines
...ain/java/org/casbin/jcasbin/main/CoreEnforcer.java 82.35% 2 Missing and 1 partial ⚠️
src/main/java/org/casbin/jcasbin/util/Util.java 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
- Coverage   69.03%   69.02%   -0.01%     
==========================================
  Files          53       53              
  Lines        2351     2373      +22     
  Branches      414      417       +3     
==========================================
+ Hits         1623     1638      +15     
- Misses        622      627       +5     
- Partials      106      108       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LMay001 LMay001 changed the title feat: add JSON process in enforce for ABAC model feat: add JSON process in enforce Feb 3, 2024
@hsluoyz hsluoyz changed the title feat: add JSON process in enforce feat: add ABAC & JSON related test cases Feb 3, 2024
@hsluoyz hsluoyz merged commit 2c363e1 into casbin:master Feb 3, 2024
3 of 5 checks passed
@LMay001 LMay001 deleted the sync_modeltest branch February 3, 2024 17:36
Copy link

github-actions bot commented Feb 3, 2024

🎉 This PR is included in version 1.46.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants