fix: concurrent access issues with HashSet<string> #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sagilio please review |
|
|
|
Thank you, I will try to reproduce the test failure scenario. |
|
@seanamorosoamtote plz sign CLA:
|
|
🎉 This PR is included in version 2.9.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Came across issues that are similar to #336
Was able to create a concurrent update of the grouping policy which would trigger concurrent access errors. It would work OK with only 100, but once you hit 500 or greater it would fail almost 100% of the time.
I don't think this should go into
masteras-is, but one of your members can take what is here and make the appropriate changes to handle the access. You can remove my code changes and just use the test and models to see the test fail.