Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancel button and fix validation bug on Get Involved form #2504

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Aug 4, 2023

Form was raising a server error if submitted blank, because the validation on trainee_notes was expecting involvement_type to be set.
Note that involvement_type is always required in TrainingProgress creation, but it has required=False set on the form. This is because at least one other field will always be required, but this is only determined at validation time, so showing an asterisk on only one field and not the rest doesn't quite represent how the form works.

Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elichad elichad merged commit 3060365 into develop Aug 4, 2023
8 checks passed
@elichad elichad deleted the feature/get-involved-validation-involvement-type branch August 4, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants