Add cancel button and fix validation bug on Get Involved form #2504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form was raising a server error if submitted blank, because the validation on
trainee_notes
was expectinginvolvement_type
to be set.Note that
involvement_type
is always required inTrainingProgress
creation, but it hasrequired=False
set on the form. This is because at least one other field will always be required, but this is only determined at validation time, so showing an asterisk on only one field and not the rest doesn't quite represent how the form works.