fix(ui): Update broken yup-ast schema #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the quick review @tiopramayudi ! Merging this now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
In caraml-dev/turing#390, the
yup-astpackage has been updated to use a much newer and updated alternative. However, after fixing that problem, it was found that the existing experiment engineyup-astschema specified in XP isn't working, i.e. the validation schema is invalid andyupallows the entire config to pass even if it fails certain fields in the validation schema.Apparently what's needed to be fix is to simply add additional square brackets when defining a list of validation checks in the schema specified for a specific field (only when using the
yup.shapecheck). I've tested these changes locally.I can't tell if this wasn't working in the past or if the schema change is only expected by the newer
@demvsystems/yup-astpackage so I'm opening both PRs to fix this issue once and for all. (Yes I know that's a TODO to clean this part up but I'm ignoring it for now to get this fix released as soon as possible since it's blocking some users from deploying their Turing routers).Which issue(s) this PR fixes:
Fixes #