Merge pull request #15 from capaj/guard-unmount

guard for unmounted component when resolving/rejecting the promise
capaj · Jan 18, 2018 · 10ef362 · 10ef362
2 parents dc885b2 + 0db1772
commit 10ef362
Showing 1 changed file with 16 additions and 8 deletions.
diff --git a/src/react-promise.js b/src/react-promise.js
@@ -29,16 +29,20 @@ class Async extends React.Component {
     })
     prom.then(
       res => {
-        this.setState({
-          status: statusTypes.resolved,
-          value: res
-        })
+        if (!this.unmounted) {
+          this.setState({
+            status: statusTypes.resolved,
+            value: res
+          })
+        }
       },
       err => {
-        this.setState({
-          status: statusTypes.rejected,
-          value: err
-        })
+        if (!this.unmounted) {
+          this.setState({
+            status: statusTypes.rejected,
+            value: err
+          })
+        }
       }
     )
   }
@@ -47,6 +51,10 @@ class Async extends React.Component {
       this.handlePromise(this.props.promise)
     }
   }
+  componentWillUnmount () {
+    this.unmounted = true
+  }
+
   render () {
     const { props, state } = this