Fix/new prefix #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artivis
reviewed
Jun 19, 2023
| @@ -7,5 +7,5 @@ TURTLEBOT3_MODEL="$(snapctl get turtlebot3-model)" | |||
| export LDS_MODEL | |||
| export TURTLEBOT3_MODEL | |||
|
|
|||
| ${SNAP}/opt/ros/noetic/bin/roslaunch turtlebot3c_bringup turtlebot3c_bringup.launch simulation:=$SIMULATION | |||
| ${SNAP}/roslaunch turtlebot3c_bringup turtlebot3c_bringup.launch simulation:=$SIMULATION | |||
There was a problem hiding this comment.
You shouldn't even need the $SNAP/ prefix in these script.
There was a problem hiding this comment.
So I tested since I thought I remembered something weird, and indeed there is something. While here in the core_launcher.sh I could remove the $SNAP it's not the case of all the scripts. The scripts mux_select_* in the command chain, when I remove the $SNAP prefix I get:
/snap/turtlebot3c/x2/usr/bin/mux_select_key_vel.sh: line 2: opt/ros/noetic/bin/rosservice: No s
uch file or directory
I am not sure if this is a bug. I am concerned that it might be confusing for users. I would prefer to keep the "$SNAP" in anything that is outside the snapcraft.yaml before we know more if it's a bug or not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to new snapcraft stable version, we can now directly use the roslaunch/rosrun prefix
Tested with the simulation