gadget: add a Size method to Volume #14561
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14561 +/- ##
==========================================
+ Coverage 78.85% 78.87% +0.01%
==========================================
Files 1079 1082 +3
Lines 145615 145969 +354
==========================================
+ Hits 114828 115127 +299
- Misses 23601 23643 +42
- Partials 7186 7199 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alfonsosanchezbeato
changed the title
upils
force-pushed
the
add-volume-max-size
branch
2 times, most recently
from
827356c
to
78a5b21
Compare
gadget/gadget.go
Outdated
| } | ||
|
|
||
| // MaxSize returns the maximum size required by a volume. | ||
| func (v *Volume) MaxSize() quantity.Size { |
There was a problem hiding this comment.
How about simply Size(), or DefaultSize() (to highlight that the volume can be expanded at install time)?
It's an odd choice for u-i to be using MinSize() really. AFAIU MinSize is there only for compatibility check during remodel/update.
Made a similar remark in the u-i PR canonical/ubuntu-image#251
There was a problem hiding this comment.
It was more than an odd choice, it was a bug!
I do not know if the gadget info is updated when the volume is expanded at install time, so I do not know if DefaultSize() would make sense or not (because if the gadget info is updated, then the value returned by DefaultSize() would not be the default anymore once the volume is expanded). But I think renaming this method to Size() makes sense.
@alfonsosanchezbeato any opinion on that?
There was a problem hiding this comment.
Maybe DefaultImageSize() as it would be the default size of a flashable image?
There was a problem hiding this comment.
I renamed it Size() because this method could be used for other purposes than giving the "Image" size, and the returned value will change if the Volume was updated so I find it confusing to use Default in the name.
upils
changed the title
This method is needed to determine the size of the disk image to create in ubuntu-image. Signed-off-by: Paul Mars <[email protected]>
upils
force-pushed
the
add-volume-max-size
branch
from
78a5b21
to
9f4c785
Compare
upils
changed the title
This method is needed to determine the size of the disk image to create in ubuntu-image.