o/snapstate, o/hookstate: run component remove hooks #14539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewphelpsj
force-pushed
the
remove-component-hooks
branch
from
e645e99
to
24184b9
Compare
pedronis
reviewed
Sep 26, 2024
overlord/hookstate/hooks.go
Outdated
| Snap: snap, | ||
| Component: component, | ||
| Hook: "remove", | ||
| Optional: true, |
There was a problem hiding this comment.
what's the IgnoreError setting on the snap remove hooks, we should be consistent?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14539 +/- ##
==========================================
+ Coverage 78.85% 78.86% +0.01%
==========================================
Files 1079 1082 +3
Lines 145615 145961 +346
==========================================
+ Hits 114828 115118 +290
- Misses 23601 23648 +47
- Partials 7186 7195 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alfonsosanchezbeato
approved these changes
Sep 30, 2024
Comment on lines
18
to
20
| if snap list test-snap-component-hooks; then | ||
| snap remove test-snap-component-hooks || true | ||
| fi |
There was a problem hiding this comment.
nitpick^2: I would go for just snap remove test-snap-component-hooks || true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change lets us run component remove hooks.