tests: adding extra scenarios for fault injection #14489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiocazzolato
added
the
Run nested
sergiocazzolato
requested review from
valentindavid and
alfonsosanchezbeato
github-actions
bot
added
the
Run Nested -auto-
This change includes some scenarios that are missing to check fault injection. In this case are included fault/reboot for: - install snapd --dangerous - remodel - install kernel component - update boot config
sergiocazzolato
force-pushed
the
tests-add-missing-fault-injection
branch
from
65bd947
to
426b153
Compare
bboozzoo
approved these changes
Sep 18, 2024
sergiocazzolato
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14489 +/- ##
==========================================
+ Coverage 78.83% 78.87% +0.03%
==========================================
Files 1078 1080 +2
Lines 145096 145826 +730
==========================================
+ Hits 114389 115017 +628
- Misses 23546 23617 +71
- Partials 7161 7192 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
alfonsosanchezbeato
approved these changes
Sep 25, 2024
Comment on lines
+12
to
+13
| #TAG/gadget_panic_config_bootloader: update-config-bootloader | ||
| #FAULT/gadget_panic_config_bootloader: panic |
There was a problem hiding this comment.
Is this the one that finishes with error? Maybe worth adding a comment on why it is commented out.
There was a problem hiding this comment.
No, this is an scenario that cannot be reproduced, I'll work on that one in a following pr, I need @valentindavid for that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes some scenarios that are missing to check fault injection.
In this case are included fault/reboot for: