Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix apt-hooks in ubuntu oracular #14155

Merged

Conversation

sergiocazzolato
Copy link
Collaborator

The error message installing a package that cannot be located has changed.

The error message installing a package that cannot be located has
changed.
@sergiocazzolato sergiocazzolato added the Simple 😃 A small PR which can be reviewed quickly label Jul 3, 2024
Copy link
Member

@olivercalder olivercalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

tests/main/apt-hooks/task.yaml Show resolved Hide resolved
Copy link
Member

@olivercalder olivercalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some duplicate lines now as my suggestion was bad, probably best to just use your original solution. Sorry for the confusion :)

Comment on lines 58 to 72
No apt package "aws-cli", but there is a snap with that name.
Try "snap install aws-cli"

E: Unable to locate package aws-cli
ERROR="E"
if os.query is-ubuntu-ge 24.10; then
ERROR="ERROR"
fi
cat > expected << EOF

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

No apt package "aws-cli", but there is a snap with that name.
Try "snap install aws-cli"

$ERROR: unable to locate package aws-cli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion doesn't work literally, the previous message needs to be deleted. But I like your original solution better anyway, sorry

@olivercalder olivercalder self-requested a review July 3, 2024 16:40
Copy link
Member

@olivercalder olivercalder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@MiguelPires MiguelPires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@sergiocazzolato sergiocazzolato merged commit 431967d into canonical:master Jul 4, 2024
83 of 106 checks passed
@sergiocazzolato sergiocazzolato deleted the tests-fix-apt-hooks-2410 branch July 4, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Simple 😃 A small PR which can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants