-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: fix apt-hooks in ubuntu oracular #14155
tests: fix apt-hooks in ubuntu oracular #14155
Conversation
The error message installing a package that cannot be located has changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some duplicate lines now as my suggestion was bad, probably best to just use your original solution. Sorry for the confusion :)
tests/main/apt-hooks/task.yaml
Outdated
No apt package "aws-cli", but there is a snap with that name. | ||
Try "snap install aws-cli" | ||
|
||
E: Unable to locate package aws-cli | ||
ERROR="E" | ||
if os.query is-ubuntu-ge 24.10; then | ||
ERROR="ERROR" | ||
fi | ||
cat > expected << EOF | ||
|
||
WARNING: apt does not have a stable CLI interface. Use with caution in scripts. | ||
|
||
No apt package "aws-cli", but there is a snap with that name. | ||
Try "snap install aws-cli" | ||
|
||
$ERROR: unable to locate package aws-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion doesn't work literally, the previous message needs to be deleted. But I like your original solution better anyway, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^
0479b7f
to
f15620e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
The error message installing a package that cannot be located has changed.