seedwriter: check if the optionSnap channel is same as model assert #14071
Conversation
AristoChen
force-pushed
the
check_option_snap_channel_with_model_assertion
branch
from
cd8b4f3
to
c1cad8d
Compare
| @@ -427,9 +427,23 @@ func (w *Writer) SetOptionsSnaps(optSnaps []*OptionsSnap) error { | |||
| if err != nil { | |||
| return fmt.Errorf("cannot use option channel for snap %q: %v", whichSnap, err) | |||
| } | |||
| if err := w.policy.checkSnapChannel(ch, whichSnap); err != nil { | |||
There was a problem hiding this comment.
AFAIU the original check is intentional and if you are using a mode with grade > dangerous, the channel is already specified in the model itself, thus it is a mistake to attempt to pass one in the command line.
Note that it is enough to pass the snap name as --snap <name> to include an optional snap. During seeding the snap will be set up to track the right channel
There was a problem hiding this comment.
The current behavior is mostly so that the check is very simple and consistent, and there is no giving the impression that one can specify a different channel if grade != dangerous. What's the use case for passing in a channel anyway? As @bboozzoo explained --snap <name> is enough to trigger inclusion of the optional snap.
If we define `presence: optional` for an app snap in the model assertion, and the default channel is `24/stable` for example, then when we pass `--snap=SNAP=24/stable` to `snap prepare-image` with a model assertion that has model grade higher than `dangerous`, I will get an error `error: cannot override channels, add devmode snaps, local snaps, or extra snaps with a model of grade higher than dangerous` However, I am expecting that snapd should check whether the channel for option snap is same as the channel defined in model assertion, maybe snapd should only return error if channel is not the same and the model grade is higher than dangerous Signed-off-by: Aristo Chen <[email protected]>
AristoChen
force-pushed
the
check_option_snap_channel_with_model_assertion
branch
from
c1cad8d
to
633b7a2
Compare
|
Thanks for the explanation! Previously I wasn't familiar with the IMO, maybe snapd should accept both I just realized that my original patch will affect all scenarios even if |
If we define
presence: optionalfor an app snap in model assertion, and the default channel is24/stablefor example, then when we pass--snap=SNAP=24/stabletosnap prepare-imagewith a model assertion that has model grade higher than dangerous, I will get an errorerror: cannot override channels, add devmode snaps, local snaps, or extra snaps with a model of grade higher than dangerousHowever, I am expecting that snapd should check whether the channel for option snap is same as the channel defined in model assertion, maybe snapd should only return error if channel is not the same and the model grade is higher than dangerous