Skip to content

Commit

Permalink
cmd/cmd_prepare_image: support for components option
Browse files Browse the repository at this point in the history
  • Loading branch information
alfonsosanchezbeato committed Jul 11, 2024
1 parent d2f1a9f commit e35fcbd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
4 changes: 4 additions & 0 deletions cmd/snap/cmd_prepare_image.go
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ type cmdPrepareImage struct {

// TODO: introduce SnapWithChannel?
Snaps []string `long:"snap" value-name:"<snap>[=<channel>]"`
Components []string `long:"comp" value-name:"<snap>+<comp>"`
ExtraSnaps []string `long:"extra-snaps" hidden:"yes"` // DEPRECATED
RevisionsFile string `long:"revisions"`
WriteRevisionsFile string `long:"write-revisions" optional:"true" optional-value:"./seed.manifest"`
Expand Down Expand Up @@ -88,6 +89,8 @@ For preparing classic images it supports a --classic mode`),
// TRANSLATORS: This should not start with a lowercase letter.
"snap": i18n.G("Include the given snap from the store or a local file and/or specify the channel to track for the given snap"),
// TRANSLATORS: This should not start with a lowercase letter.
"comp": i18n.G("Include the given component from the store or a local file"),
// TRANSLATORS: This should not start with a lowercase letter.
"extra-snaps": i18n.G("Extra snaps to be installed (DEPRECATED)"),
// TRANSLATORS: This should not start with a lowercase letter.
"revisions": i18n.G("Specify a seeds.manifest file referencing the exact revisions of the provided snaps which should be installed"),
Expand Down Expand Up @@ -123,6 +126,7 @@ func (x *cmdPrepareImage) Execute(args []string) error {

opts := &image.Options{
Snaps: x.ExtraSnaps,
Components: x.Components,
ModelFile: x.Positional.ModelAssertionFn,
Channel: x.Channel,
Architecture: x.Architecture,
Expand Down
3 changes: 2 additions & 1 deletion cmd/snap/cmd_prepare_image_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ func (s *SnapPrepareImageSuite) TestPrepareImageExtraSnaps(c *C) {
r := cmdsnap.MockImagePrepare(prep)
defer r()

rest, err := cmdsnap.Parser(cmdsnap.Client()).ParseArgs([]string{"prepare-image", "model", "prepare-dir", "--channel", "candidate", "--snap", "foo", "--snap", "bar=t/edge", "--snap", "local.snap", "--extra-snaps", "local2.snap", "--extra-snaps", "store-snap"})
rest, err := cmdsnap.Parser(cmdsnap.Client()).ParseArgs([]string{"prepare-image", "model", "prepare-dir", "--channel", "candidate", "--snap", "foo", "--snap", "bar=t/edge", "--snap", "local.snap", "--extra-snaps", "local2.snap", "--extra-snaps", "store-snap", "--comp", "local.comp", "--comp", "bar+comp1"})
c.Assert(err, IsNil)
c.Assert(rest, DeepEquals, []string{})

Expand All @@ -140,6 +140,7 @@ func (s *SnapPrepareImageSuite) TestPrepareImageExtraSnaps(c *C) {
Channel: "candidate",
PrepareDir: "prepare-dir",
Snaps: []string{"foo", "bar", "local.snap", "local2.snap", "store-snap"},
Components: []string{"local.comp", "bar+comp1"},
SnapChannels: map[string]string{"bar": "t/edge"},
})
}
Expand Down

0 comments on commit e35fcbd

Please sign in to comment.