Skip to content

Commit

Permalink
o/hookstate/ctlcmd: explain why configure hook is not tested for sing…
Browse files Browse the repository at this point in the history
…le transaction

Signed-off-by: Zeyad Gouda <[email protected]>
  • Loading branch information
ZeyadYasser committed Jul 1, 2024
1 parent 8b3000e commit 56a6bae
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions overlord/hookstate/ctlcmd/services_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -689,6 +689,17 @@ func (s *servicectlSuite) TestQueuedCommandsOrderingConfigureHook(c *C) {
s.testQueuedCommandsOrdering(c, hook, singleTransaction)
}

// NOTE: It is tricky to get snap name for all task kinds in the case of configure hook
// so this test is left commented out just for clarity, but it will fail.
// This is a non-issue for configure hook since the command tasks are queued at the very
// end of the change unlike the default-configure hook.
//
// func (s *servicectlSuite) TestQueuedCommandsOrderingConfigureHookSingleTransaction(c *C) {
// const hook = "configure"
// const singleTransaction = true
// s.testQueuedCommandsOrdering(c, hook, singleTransaction)
// }

func (s *servicectlSuite) testQueueCommandsConfigureHookFinalTask(c *C, finalTaskKind string) {
s.st.Lock()

Expand Down

0 comments on commit 56a6bae

Please sign in to comment.