Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: build, sign and publish registries #5072

Merged
merged 6 commits into from
Oct 2, 2024
Merged

feat: build, sign and publish registries #5072

merged 6 commits into from
Oct 2, 2024

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Sep 26, 2024 •
edited
Loading

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox run -m lint?
  • Have you successfully run tox run -e test-py310? (supported versions: py39, py310, py311, py312)

Finalizes support for the edit-registries command by building, signing and publishing registries.

(CRAFT-3331)
Fixes #5018

@mr-cal mr-cal force-pushed the work/CRAFT-3331/publish-registries branch from b2e26d3 to a161e44 Compare September 27, 2024 16:46
@mr-cal mr-cal marked this pull request as ready for review September 27, 2024 16:57
@mr-cal
fix: improve types
321b36e 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal mr-cal added the squash label Sep 30, 2024
@mr-cal mr-cal requested a review from tigarmo September 30, 2024 19:55
tigarmo
tigarmo approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks fine to me. I understand that the spread tests are coming in a separate PR?

snapcraft/services/assertions.py Outdated Show resolved Hide resolved
snapcraft/services/assertions.py Outdated Show resolved Hide resolved
snapcraft/services/assertions.py Outdated Show resolved Hide resolved
@mr-cal
chore: feedback from PR
02777ac 
Signed-off-by: Callahan Kovacs <[email protected]>
@mr-cal mr-cal requested a review from tigarmo October 1, 2024 21:26
@mr-cal
Copy link
Collaborator Author

mr-cal commented Oct 1, 2024

I understand that the spread tests are coming in a separate PR?

Correct

@mr-cal mr-cal requested review from tigarmo and removed request for cmatsuoka and tigarmo October 2, 2024 15:15
@mr-cal mr-cal merged commit 932f9e4 into main Oct 2, 2024
13 checks passed
@mr-cal mr-cal deleted the work/CRAFT-3331/publish-registries branch October 2, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiusens sergiusens sergiusens left review comments

@lengau lengau lengau approved these changes

@tigarmo tigarmo Awaiting requested review from tigarmo

Assignees
No one assigned
Labels
squash
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

registries: sign and upload registries
4 participants
@mr-cal @sergiusens @tigarmo @lengau