Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repos: revert package-repositories changes for core18 and core20 #4279

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

tigarmo
Copy link
Contributor

@tigarmo tigarmo commented Jul 14, 2023

This PR restores the original (pre-craft-archives) support for package-repositories for core18 and core20. This is done by reverting the changes done to the snapcraft_legacy/ tree (and its tests) in these two commits:

  • 0e12894 (requirements: update craft-archives)
  • ce23bc7 (repo: migrate to craft-archives)

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2023

Codecov Report

Merging #4279 (a3cff2a) into hotfix/7.5 (4d7eab2) will increase coverage by 0.02%.
The diff coverage is 96.75%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@              Coverage Diff               @@
##           hotfix/7.5    #4279      +/-   ##
==============================================
+ Coverage       94.85%   94.88%   +0.02%     
==============================================
  Files             649      657       +8     
  Lines           54449    55116     +667     
==============================================
+ Hits            51650    52297     +647     
- Misses           2799     2819      +20     
Impacted Files Coverage Δ
...apcraft_legacy/internal/meta/package_repository.py 90.00% <90.00%> (ø)
snapcraft_legacy/internal/repo/apt_ppa.py 90.90% <90.90%> (ø)
...pcraft_legacy/internal/repo/apt_sources_manager.py 95.40% <95.40%> (ø)
snapcraft_legacy/internal/repo/apt_key_manager.py 98.59% <98.59%> (ø)
snapcraft_legacy/internal/meta/snap.py 97.67% <100.00%> (ø)
...napcraft_legacy/internal/project_loader/_config.py 92.76% <100.00%> (ø)
snapcraft_legacy/plugins/v1/_plugin.py 95.91% <100.00%> (ø)
snapcraft_legacy/plugins/v1/catkin.py 93.99% <100.00%> (ø)
snapcraft_legacy/plugins/v1/colcon.py 98.30% <100.00%> (ø)
tests/legacy/unit/meta/test_package_repository.py 100.00% <100.00%> (ø)
... and 3 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens merged commit 706872e into hotfix/7.5 Jul 14, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants