Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: write out metadata links #4275

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Conversation

sergiusens
Copy link
Collaborator

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Fixes #4238

@sergiusens sergiusens changed the base branch from main to hotfix/7.5 July 12, 2023 23:24
@sergiusens sergiusens changed the title Work/craft 1842 metadatalinks meta: write out metadata links Jul 12, 2023
@sergiusens sergiusens closed this Jul 12, 2023
@sergiusens sergiusens reopened this Jul 12, 2023
@sergiusens sergiusens force-pushed the work/CRAFT-1842-metadatalinks branch 2 times, most recently from 91a74bd to 51587c4 Compare July 13, 2023 00:27
@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2023

Codecov Report

Merging #4275 (dacb3fa) into hotfix/7.5 (cfacbc5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           hotfix/7.5    #4275   +/-   ##
===========================================
  Coverage       94.85%   94.85%           
===========================================
  Files             649      649           
  Lines           54379    54431   +52     
===========================================
+ Hits            51580    51632   +52     
  Misses           2799     2799           
Impacted Files Coverage Δ
snapcraft/meta/snap_yaml.py 96.87% <100.00%> (+0.23%) ⬆️
tests/unit/meta/test_snap_yaml.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens force-pushed the work/CRAFT-1842-metadatalinks branch 2 times, most recently from 3d5123a to f97016b Compare July 13, 2023 01:15
Signed-off-by: Sergio Schvezov <[email protected]>
@sergiusens sergiusens force-pushed the work/CRAFT-1842-metadatalinks branch from f97016b to dacb3fa Compare July 13, 2023 02:25
@sergiusens sergiusens marked this pull request as ready for review July 13, 2023 10:47
@sergiusens
Copy link
Collaborator Author

the only error is ros2-humble and the library linter check

@sergiusens sergiusens requested a review from mr-cal July 13, 2023 11:40
Copy link
Collaborator

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice design!

@sergiusens sergiusens merged commit de56fe6 into hotfix/7.5 Jul 13, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata links are ignored in core22 snaps
3 participants