docs: rewrite the explanation section #327
Conversation
SamirPS
force-pushed
the
explanation-section
branch
2 times, most recently
from
d9f1012
to
95be9ad
Compare
SamirPS
force-pushed
the
explanation-section
branch
from
770caba
to
aae4f98
Compare
SamirPS
force-pushed
the
explanation-section
branch
3 times, most recently
from
d142dc1
to
010be0b
Compare
This PR add the explanation of Pebble and rewrite chisel,rocks and overlay-step explanation. Co-authored-by: Cristovao Cordeiro <[email protected]>
SamirPS
force-pushed
the
explanation-section
branch
from
010be0b
to
156e048
Compare
…to explanation-section
cjdcordeiro
requested review from
cjdcordeiro
and removed request for
cjdcordeiro
|
LGTM ping @pedroleaoc for review @cjdcordeiro text |
cjdcordeiro
requested review from
tigarmo,
cjdcordeiro and
dboddie
and removed request for
cjdcordeiro and
dboddie
Co-authored-by: Tiago Nobrega <[email protected]>
Co-authored-by: Tiago Nobrega <[email protected]>
|
thanks for the review @tigarmo I've updated the PR. Please note that this PR also contains a fix for the currently broken docs header styling -> https://canonical-rockcraft.readthedocs-hosted.com/en/latest/ |
cjdcordeiro
requested review from
tigarmo and
lengau
and removed request for
dboddie
sergiusens
changed the title
Co-authored-by: Sergio Schvezov <[email protected]>
There was a problem hiding this comment.
This looks great! (And please keep them coming — reviewing documentation PRs is honestly one of the best ways to keep keep me up to date on the state of Rockcraft, so I'm grateful for the opportunity.)
The comments I've added below are with my mental "grammar and style knobs" tuned to maximum sensitivity. None of them are strictly necessary, but I'd rather offer 10 suggestions where you prefer the original for 9 of them than miss an improvement you'd like too. So feel free to pick and choose only the suggestions you personally prefer — even if that turns out to be none of them.
Co-authored-by: Alex Lowe <[email protected]>
Co-authored-by: Alex Lowe <[email protected]>
This PR add the explanation of Pebble and
rewrite chisel,rocks and overlay-step explanation.
Fixes #337
Fixes #348
https://canonical-rockcraft--327.com.readthedocs.build/en/327/