-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add NGINX rock #9
Conversation
cbf42d8
Test coverage for 7c71c7b
Static code analysis report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the overall is great, but I have one question related to this: why not include nginx in the maubot image and use pebble to run both the maubot service and nginx in the same container? Is there any reason for using two containers?
application/x-javascript | ||
application/xml | ||
application/xml+rss | ||
image/png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: probably don't need to compress PNG files.
log_format main '$remote_addr - $remote_user [$time_local] "$request" ' | ||
'$status $body_bytes_sent "$http_referer" ' | ||
'"$http_user_agent" "$http_x_forwarded_for" "$http_x_forwarded_proto"'; | ||
access_log /var/log/nginx/access.log main; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the access log should be logged to stdout, as the error log is logged to stderr?
Thats an excellent question. I cant think of any reason for having two containers! |
I'll close this PR and add NGINX to Maubot. Thanks @weiiwang01 ! |
Applicable spec:
Overview
This PR adds a NGINX rock and pebble layer to the Maubot charm.
Rationale
NGINX will act as a proxy.
Note:
Juju Events Changes
Add NGINX pebble ready event.
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)No CH available.