Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add public-url config #12

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: add public-url config #12

wants to merge 5 commits into from

Conversation

amandahla
Copy link
Contributor

Applicable spec:

Overview

Adds public-url configuration.

"The public URL where the resources are available. The base path is automatically appended to this."
Extracted from the example config.

Rationale

Allow the user to change the public URL if needed.

Juju Events Changes

Module Changes

Library Changes

Checklist

No CH available yet.

nrobinaubertin
nrobinaubertin previously approved these changes Sep 24, 2024
charmcraft.yaml Outdated Show resolved Hide resolved
tests/unit/conftest.py Show resolved Hide resolved
tests/unit/test_charm.py Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Oct 3, 2024

Test coverage for a787708

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      75      5     10      2    92%   104, 108, 117, 138, 141
----------------------------------------------------------
TOTAL             75      5     10      2    92%

Static code analysis report

Run started:2024-10-03 13:16:46.228698

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 344
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants