Auth: Implement identity deletion #14191
Open
+6,652
−5,745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
markylaing
force-pushed
the
delete-identities
branch
from
1536557
to
b6caec1
Compare
|
Heads up @mionaalex - the "Documentation" label was applied to this issue. |
markylaing
force-pushed
the
delete-identities
branch
from
b6caec1
to
f7268ec
Compare
hamistao
requested changes
Oct 3, 2024
Signed-off-by: Mark Laing <[email protected]>
This commit is in preparation for the addition of fine-grained TLS identities. The endpoint for TLS identity creation will be `POST /1.0/auth/identities/tls`. We want this to be separated from the OIDC authentication method because the request body and API responses are specific to TLS authentication. Since the identity is saved in the request context by the access handler, the main work here is updating the `getIdentities` handler to accept an authentication method and return a handler for that method. If no authentication method is given, the handler will return all identities. Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
Signed-off-by: Mark Laing <[email protected]>
markylaing
force-pushed
the
delete-identities
branch
from
f7268ec
to
94ff84e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
access_management_tlsAPI extension which will apply to all upcoming changes for TLS fine-grained auth.Note: The licence check was failing in my local static analysis, not sure what's happening there.
Note 2: (I just needed to update it locally 👍).
Closes #13149