-
Notifications
You must be signed in to change notification settings - Fork 930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lxc file create
subcommand (from Incus)
#14188
Open
kadinsayani
wants to merge
5
commits into
canonical:main
Choose a base branch
from
kadinsayani:incus-file-create
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadinsayani
force-pushed
the
incus-file-create
branch
3 times, most recently
from
October 2, 2024 01:09
3e550a2
to
bd9aeb7
Compare
simondeziel
previously approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a small question
This adds the `lxc file create` subcommand which allows creating files, symlinks, and directories without specifying a source. Signed-off-by: Thomas Hipp <[email protected]> (cherry picked from commit 2f52e021ab61a8a371740910705020bf8760f803) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
This adds tests for the new `lxc file create` subcommand. Signed-off-by: Thomas Hipp <[email protected]> (cherry picked from commit 2325e194a47041e7a161482a4473e411c1f64a8d) Signed-off-by: Kadin Sayani <[email protected]> License: Apache-2.0
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
Signed-off-by: Kadin Sayani <[email protected]>
kadinsayani
force-pushed
the
incus-file-create
branch
from
October 2, 2024 15:25
bd9aeb7
to
cd45537
Compare
simondeziel
approved these changes
Oct 2, 2024
tests are unhappy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from lxc/incus#408. I've also added instance shell completions for
lxc file
subcommands.Signed-off-by: Kadin Sayani [email protected]