Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lxc file create subcommand (from Incus) #14188

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kadinsayani
Copy link
Contributor

@kadinsayani kadinsayani commented Oct 1, 2024

Cherry-picked from lxc/incus#408. I've also added instance shell completions for lxc file subcommands.

Signed-off-by: Kadin Sayani [email protected]

lxc/file.go Fixed Show fixed Hide fixed
@kadinsayani kadinsayani force-pushed the incus-file-create branch 3 times, most recently from 3e550a2 to bd9aeb7 Compare October 2, 2024 01:09
simondeziel
simondeziel previously approved these changes Oct 2, 2024
Copy link
Member

@simondeziel simondeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small question

lxc/file.go Outdated Show resolved Hide resolved
monstermunchkin and others added 5 commits October 2, 2024 09:24
This adds the `lxc file create` subcommand which allows creating
files, symlinks, and directories without specifying a source.

Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit 2f52e021ab61a8a371740910705020bf8760f803)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
This adds tests for the new `lxc file create` subcommand.

Signed-off-by: Thomas Hipp <[email protected]>
(cherry picked from commit 2325e194a47041e7a161482a4473e411c1f64a8d)
Signed-off-by: Kadin Sayani <[email protected]>
License: Apache-2.0
Signed-off-by: Kadin Sayani <[email protected]>
@tomponline
Copy link
Member

tests are unhappy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants