Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and cleans up longhorn engine rock #32

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

claudiubelu
Copy link
Contributor

The rock should contain the longhorn-instance-manager, but longhorn-engine is built and included instead.

Removes redundant liblonghorn clone and installation.

@claudiubelu claudiubelu requested a review from a team as a code owner September 16, 2024 14:07
@claudiubelu claudiubelu marked this pull request as draft September 16, 2024 14:07
@claudiubelu claudiubelu marked this pull request as ready for review September 16, 2024 14:49
Copy link
Collaborator

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, then good to merge

v1.7.0/longhorn-engine/rockcraft.yaml Show resolved Hide resolved
The rock should contain the longhorn-instance-manager, but
longhorn-engine is built and included instead.

Removes redundant liblonghorn clone and installation.
@bschimke95 bschimke95 merged commit 07875c1 into canonical:main Sep 19, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants