Adds longhorn-manager command patch #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original longhorn-manager image doesn't have an entrypoint, only a CMD. This means that when the image is launched, it will run the CMD directly. Basically, the CMD is the ENTRYPOINT (binary + arguments). That works fine with the current deployments. longhorn-manager will create the daemonset.apps/longhorn-csi-plugin, which will have a longhorn-manager container, which doesn't override the entrypoint, only the args (aka CMD). But in our rock scenario, Pebble is the entrypoint, which will get those arguments and pass them on onto the service defined above. This results in an invalid command being run, something like: longhorn-manager -d daemon longhorn-manager -d csi --nodeid=... This patch updates the mentioned container args to command, overriding the Pebble entrypoint, avoiding this problem.
berkayoz
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original longhorn-manager image doesn't have an entrypoint, only a
CMD. This means that when the image is launched, it will run theCMDdirectly. Basically, theCMDis theENTRYPOINT(binary + arguments). That works fine with the current deployments.longhorn-manager will create the
daemonset.apps/longhorn-csi-plugin, which will have a longhorn-manager container, which doesn't override the entrypoint, only the args (akaCMD).But in our rock scenario, Pebble is the entrypoint, which will get those arguments and pass them on onto the service defined above. This results in an invalid command being run, something like:
This patch updates the mentioned container args to command, overriding the Pebble entrypoint, avoiding this problem.