Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Beta] Stage opensc-pkcs11.so and layout it. #87

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

nteodosio
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@seb128 seb128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense to move that forward and merge in beta now. @bandali0 do you agree?

@nteodosio
Copy link
Collaborator Author

A note I forgot to add is that this is a confirmed fix from the affected users.

@bandali0, when you review this, can you also review #86 together?

Copy link
Member

@bandali0 bandali0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @nteodosio thanks for the PRs and sorry for the slow reply here. Firefox snap beta and stable are still on core22, so I believe we have to use the old environment variable names here, such as $CRAFT_ARCH_TRIPLET.

@nteodosio
Copy link
Collaborator Author

Hey @bandali0, no problem.

Judging by https://snapcraft.io/docs/parts-environment-variables#heading--locating-directories-core22 the variable is there in core22 too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants