-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): Update tutorial #296
base: main
Are you sure you want to change the base?
Conversation
Test coverage for 13b5ec1
Static code analysis report
|
juju deploy nginx-ingress-integrator | ||
# If your cluster has RBAC enabled you'll be prompted to run the following: | ||
#If your cluster has RBAC enabled, you'll be prompted to run the following (If you are working inside the Multipass vm, chances are you have RBAC enabled): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that adding a way to check for RBAC wouldn't hurt here (microk8s status
)
|
||
Add the ip address to the /etc/hosts file: | ||
```bash | ||
echo "10.131.49.76 discourse-k8s" >> /etc/hosts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would change this to: echo "10.131.49.76 discourse-k8s" | sudo tee -a /etc/hosts
First get the Multipass instances IP address. Since the indico is served on the local address of the Multipass VM we need to use the ip address of the VM. To get the IP address of a Multipass instance run the following command: | ||
|
||
```bash | ||
ip a | awk '/inet .* ens3/{print $2}' | cut -d'/' -f1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will fail in many cases (for example if not using the qemu backend and instead using the lxd backend in multipass). I would use instead:
ip -4 -j route get 2.2.2.2 | jq -r '.[] | .prefsrc'
@@ -10,17 +10,25 @@ In this tutorial, we'll go through each step of the process to get a basic Disco | |||
|
|||
## Requirements | |||
|
|||
* A laptop or desktop running Ubuntu (or you can use a VM). | |||
* Juju and [Microk8s](https://juju.is/docs/olm/microk8s) installed. We’ll also want to make sure the ingress add-on is enabled, which we can do by running `microk8s enable ingress`. | |||
- A laptop or desktop running Ubuntu (or you can use a VM). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest changing this line to "A working station, e.g., a laptop, with amd64 architecture."
Overview
Standarise the Discourse tutorial with other tutorials and improve/fix the tutorial.
Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)