Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(models): coerce numbers to strings #50

Merged
merged 2 commits into from
Sep 18, 2024
Merged

fix(models): coerce numbers to strings #50

merged 2 commits into from
Sep 18, 2024

Conversation

lengau
Copy link
Contributor

@lengau lengau commented Sep 17, 2024

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run tox?

@lengau lengau marked this pull request as ready for review September 17, 2024 00:48
@lengau lengau requested review from tigarmo, mr-cal and a team September 17, 2024 00:48
@mr-cal mr-cal mentioned this pull request Sep 17, 2024
Closed
3 tasks
tigarmo
tigarmo approved these changes Sep 17, 2024
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix! As we discussed the code is getting very hairy but the fix is welcome and any refactoring is definitely beyond the scope of this PR ;)

mr-cal
mr-cal approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@mr-cal mr-cal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lengau lengau merged commit 3c244fa into main Sep 18, 2024
22 checks passed
@lengau lengau deleted the work/49/CRAFT-3389/coerce branch September 18, 2024 17:13
@mr-cal mr-cal mentioned this pull request Sep 18, 2024
Closed
3 tasks
@lengau lengau linked an issue Sep 19, 2024 that may be closed by this pull request
craft-grammar does not coerce numbers to strings in annotated types #49
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattculler mattculler mattculler left review comments

@tigarmo tigarmo tigarmo approved these changes

@mr-cal mr-cal mr-cal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

craft-grammar does not coerce numbers to strings in annotated types
4 participants
@lengau @tigarmo @mr-cal @mattculler