Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove upstream llvm repo, drop llvm 10, introduce arm builds #10

Merged
merged 3 commits into from
May 22, 2024
Merged

Remove upstream llvm repo, drop llvm 10, introduce arm builds #10

merged 3 commits into from
May 22, 2024

Conversation

berkayoz
Copy link
Member

@berkayoz berkayoz commented Apr 30, 2024 •
edited
Loading

  • Removed upstream llvm repositories due to missing arm builds on llvm 10
  • Dropped llvm 10 requirement(replaced by llvm 15 for everything)
  • Switched to pulling iptables(1.8.7) from ubuntu repo instead
  • Fixed iptables-wrapper not being staged properly
  • Added a cherry picked commit that adds new debug symbols present in llvm 10+ to the ignore list(fixes the warnings)
  • Introduced arm builds

@berkayoz berkayoz marked this pull request as ready for review May 8, 2024 09:17
addyess
addyess approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Amazing job.

i can't say i really know all that's going in iptables-wrapper-installer.sh but it's good

@addyess addyess merged commit 81c48ba into main May 22, 2024
6 checks passed
@berkayoz berkayoz mentioned this pull request May 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addyess addyess addyess approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@berkayoz @addyess