Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22.04] Add slices for various media encoding libs #48

Closed
wants to merge 0 commits into from
Closed

[22.04] Add slices for various media encoding libs #48

wants to merge 0 commits into from

Conversation

ozanmakes
Copy link

These are some useful video and image encoding libraries from main and universe repos.

@ozanmakes
Copy link
Author

P.S. what is the policy for including libraries such as libfdk-aac2 from multiverse repository?

Currently multiverse repo is not enabled in chisel.yaml. Is it against policy to enable this repo because of licensing reasons? In that case, what would be the suggestion? At the moment I'm running a fork of this repo to build my app but I would like to upstream all my slices and switch to the default repo.

@ozanmakes ozanmakes changed the title Add various media encoding libs [22.04] Add slices for various media encoding libs Aug 8, 2023
rebornplusplus
rebornplusplus requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the slices! I have left a few comments.

slices/libmpeg2-4.yaml Outdated Show resolved Hide resolved
slices/libvpx7.yaml Outdated Show resolved Hide resolved
slices/libx264-163.yaml Outdated Show resolved Hide resolved
slices/libx264-163.yaml Outdated Show resolved Hide resolved
slices/libx265-199.yaml Outdated Show resolved Hide resolved
@rebornplusplus
Copy link
Member

P.S. what is the policy for including libraries such as libfdk-aac2 from multiverse repository?

Currently multiverse repo is not enabled in chisel.yaml. Is it against policy to enable this repo because of licensing reasons? In that case, what would be the suggestion? At the moment I'm running a fork of this repo to build my app but I would like to upstream all my slices and switch to the default repo.

Good question! ping @niemeyer @cjdcordeiro @jnsgruk

@cjdcordeiro
Copy link
Collaborator

P.S. what is the policy for including libraries such as libfdk-aac2 from multiverse repository?
Currently multiverse repo is not enabled in chisel.yaml. Is it against policy to enable this repo because of licensing reasons? In that case, what would be the suggestion? At the moment I'm running a fork of this repo to build my app but I would like to upstream all my slices and switch to the default repo.

Good question! ping @niemeyer @cjdcordeiro @jnsgruk

No way to do that yet, unfortunately, and support for it is yet to be discussed, but at first glance, it might be something chisel would support in the future

@cjdcordeiro cjdcordeiro mentioned this pull request Feb 22, 2024
Merged
@linostar linostar self-requested a review May 16, 2024 07:21
@linostar
Copy link
Collaborator

Hi @ozanmakes
Are you still interested in having those slices merged? In which case, can you please update them with the changes requested?

@rebornplusplus rebornplusplus added the decaying It's been a while, close or act on it label Aug 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 1, 2024 •
edited
Loading

Diff of dependencies:
None found.

@rebornplusplus
Copy link
Member

rebornplusplus commented Aug 1, 2024 •
edited
Loading

Hi @ozanmakes, as Anas noted above, it has been some time since the last activity here. There are some changes requested as well. Will you please let me know if you have some time to go over the comments and update the PR? Thank you!

cjdcordeiro
cjdcordeiro approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rebornplusplus can you please have a look

slices/libmpeg2-4.yaml Outdated Show resolved Hide resolved
slices/libvpx7.yaml Outdated Show resolved Hide resolved
slices/libx264-163.yaml Outdated Show resolved Hide resolved
slices/libx264-163.yaml Outdated Show resolved Hide resolved
slices/libx265-199.yaml Outdated Show resolved Hide resolved
@cjdcordeiro
Copy link
Collaborator

@ozanmakes if you sign the CLA we'd be happy to keep you as the author of these commits.

In any case, the PR should be ready to go

@cjdcordeiro cjdcordeiro removed the decaying It's been a while, close or act on it label Sep 26, 2024
linostar
linostar approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@linostar linostar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cjdcordeiro cjdcordeiro mentioned this pull request Sep 27, 2024
Open
@cjdcordeiro
Copy link
Collaborator

moving to #354

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebornplusplus rebornplusplus rebornplusplus requested changes

@linostar linostar linostar approved these changes

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ozanmakes @rebornplusplus @cjdcordeiro @linostar