Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): openjdk-11 headless slices #349

Open
wants to merge 29 commits into
base: ubuntu-24.04
Choose a base branch
from

Conversation

vpa1977
Copy link

@vpa1977 vpa1977 commented Sep 18, 2024

Proposed changes

Add openjdk-11 slices except AWT slice.

Related issues/PRs

Forward porting

Checklist

Additional Context

@vpa1977 vpa1977 changed the title feat: openjdk-11 slices feat: openjdk-11 headless slices Sep 18, 2024
Copy link

github-actions bot commented Sep 18, 2024

Diff of dependencies:

slices/openjdk-11-jre-headless.yaml
@@ -1,11 +1,6 @@
-ca-certificates-java
-java-common
 libc6
 libgcc-s1
-libjpeg8
-liblcms2-2
 libnss3
 libpcsclite1
 libstdc++6
-util-linux
 zlib1g

@vpa1977 vpa1977 changed the title feat: openjdk-11 headless slices feat(24.04): openjdk-11 headless slices Sep 18, 2024
@vpa1977 vpa1977 force-pushed the 24.04-openjdk-11 branch 10 times, most recently from d61a49e to 205cadc Compare September 18, 2024 04:30
Add openjdk-11 slices except AWT slice as it needs harfbuzz to be merged.
@vpa1977 vpa1977 marked this pull request as ready for review September 18, 2024 05:04
@vpa1977
Copy link
Author

vpa1977 commented Sep 27, 2024

Needs arm64 pipeline retry

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have exactly the same comments here as in #313 (comment) and also about the dependency diff and testing of the remaining binaries.

add tests and update slice dependencies
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes. LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants