Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(24.04): add libcrack-runtime and its dependencies #329

Open
wants to merge 5 commits into
base: ubuntu-24.04
Choose a base branch
from

Conversation

Meulengracht
Copy link
Member

Proposed changes

Proposing libcrack-runtime and the dependencies it has. Unfortunately I was not able to write a mutation script that does what update-cracklib does due to limitations in how we write files. We need the capability to write raw file bytes instead of formatted as text, as it otherwise results in malaligned files.

Forward porting

I can propose this for 24.10 when this is approved

Checklist

Additional Context

My attempt at the mutation script: https://paste.ubuntu.com/p/Jc5vvgk3tN/

Copy link

github-actions bot commented Sep 3, 2024

Diff of dependencies:

slices/cracklib-runtime.yaml
@@ -1,3 +1,6 @@
 file
+findutils
+grep
 libc6
 libcrack2
+libssl3t64

- libmagic-mgc_copyright

slices:
config:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this slice data since these files are binary not easily edited?

Copy link
Member

@rebornplusplus rebornplusplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes! I left a few comments below.

In addition to the changes, could you please add a spread test for file as well? Just a smoke test will do. :)

# Cracklib runs /usr/sbin/update-cracklib on install, and this
# in turns generate the cracklib caches. This is mostly possible to do
# as a mutation script, and is provided here:
# https://paste.ubuntu.com/p/Jc5vvgk3tN/
Copy link
Member

@rebornplusplus rebornplusplus Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work there! It's a shame we cannot write raw bytes yet.
On another note, could this link expire some day? If so, I would want there to be something that does not expire, Github Gist maybe?

Comment on lines +4 to +5
- -ubuntu-24.04-ppc64le
- -ubuntu-24.04-s390x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious to know why you don't need these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants